Page MenuHomePhabricator
Differential D6643

[backport#pr16542 2/4] Give more errors for specific failure conditions
ClosedPublic
Actions

Authored by majcosta on Jun 18 2020, 19:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCa2c1a34f16f8: [backport#pr16542 2/4] Give more errors for specific failure conditions
Summary

Some failure conditions implicitly fail by failing some other check.
But the error messages are more helpful if they say explicitly what
actually caused the failure, so add those as failure conditions and
errors.

https://github.com/bitcoin/bitcoin/pull/16542/commits/625534d7b1417da926f1ced600855ea818d6e01e

Depends on D6642

Partial backport of Core PR16542

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 18 2020, 19:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 18 2020, 19:40
majcosta requested review of this revision.Jun 18 2020, 19:40
teamcity edited the summary of this revision. (Show Details)Jun 18 2020, 19:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11572: Diff 21538.Jun 18 2020, 19:52
majcosta added a child revision: D6648: [backport#16542 3/4] Check error messages in descriptor tests.Jun 18 2020, 22:02
deadalnix accepted this revision.Jun 18 2020, 23:20
This revision is now accepted and ready to land.Jun 18 2020, 23:20
majcosta edited the summary of this revision. (Show Details)Jun 21 2020, 19:23
majcosta added a parent revision: D6642: [backport#16542 1/4] Return an error from descriptor Parse that gives more information about what failed.
Closed by commit rABCa2c1a34f16f8: [backport#pr16542 2/4] Give more errors for specific failure conditions (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJul 1 2020, 15:22
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa2c1a34f16f8: [backport#pr16542 2/4] Give more errors for specific failure conditions.

Revision Contents
Changeset List

PathSize
src/
rpc/
6 lines
4 lines
script/
55 lines
wallet/
3 lines
test/
functional/
4 lines
2 lines

Diff 21927

View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/rpc_deriveaddresses.py

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...