Page MenuHomePhabricator
Differential D6626

[backport#15427 3/3] Add support for descriptors to utxoupdatepsbt
ClosedPublic
Actions

Authored by majcosta on Jun 17 2020, 18:19.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rABC4bfb19a4c357: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt
Summary

This adds a descriptors argument to the utxoupdatepsbt RPC. This means:

  • Input and output scripts and keys will be filled in when known
  • P2SH-witness outputs will be filled in from the UTXO set when a descriptor is provided to show they're segwit outputs.

https://github.com/bitcoin/bitcoin/pull/15427/commits/26fe9b990995f9cb5eee21d40b4daaad19f7181f

Depends on D6624

Concludes backport of Core PR15427

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 17 2020, 18:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2020, 18:19
majcosta requested review of this revision.Jun 17 2020, 18:19
teamcity edited the summary of this revision. (Show Details)Jun 17 2020, 18:19

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11548: Diff 21501.Jun 17 2020, 18:32
Fabien requested changes to this revision.Jun 18 2020, 10:04
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
1658 ↗(On Diff #21501)

Remove segwit reference

test/functional/rpc_psbt.py
288 ↗(On Diff #21501)

Remove

296 ↗(On Diff #21501)

Dito

This revision now requires changes to proceed.Jun 18 2020, 10:04
majcosta updated this revision to Diff 21531.Jun 18 2020, 18:06

tried to remove parts of the test that do not apply and make it more informative

majcosta added a child revision: D6641: [backport#15751] Speed up deriveaddresses for large ranges.Jun 18 2020, 18:12
Harbormaster completed remote builds in B11569: Diff 21531.Jun 18 2020, 18:20
deadalnix requested changes to this revision.Jun 20 2020, 02:27
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/rpc/rawtransaction.cpp
1658 ↗(On Diff #21531)

dewitnessify

This revision now requires changes to proceed.Jun 20 2020, 02:27
majcosta updated this revision to Diff 21582.Jun 22 2020, 04:46

addressed comments

Harbormaster completed remote builds in B11597: Diff 21582.Jun 22 2020, 05:00
majcosta updated this revision to Diff 21591.Jun 22 2020, 08:31

removed additional segwit/bech32 references

Harbormaster completed remote builds in B11606: Diff 21591.Jun 22 2020, 08:43
deadalnix accepted this revision.Jun 22 2020, 21:47
Fabien accepted this revision.Jun 23 2020, 07:13
This revision is now accepted and ready to land.Jun 23 2020, 07:13
Closed by commit rABC4bfb19a4c357: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 23 2020, 18:39
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC4bfb19a4c357: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.

Revision Contents
Changeset List

PathSize
src/
rpc/
64 lines
test/
functional/
20 lines

Diff 21661

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...