Page MenuHomePhabricator

[backport#15427 3/3] Add support for descriptors to utxoupdatepsbt
ClosedPublic

Authored by majcosta on Jun 17 2020, 18:19.

Details

Summary

This adds a descriptors argument to the utxoupdatepsbt RPC. This means:

  • Input and output scripts and keys will be filled in when known
  • P2SH-witness outputs will be filled in from the UTXO set when a descriptor is provided to show they're segwit outputs.

https://github.com/bitcoin/bitcoin/pull/15427/commits/26fe9b990995f9cb5eee21d40b4daaad19f7181f


Depends on D6624

Concludes backport of Core PR15427

Test Plan
ninja check-all

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Jun 18 2020, 10:04
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
1658 ↗(On Diff #21501)

Remove segwit reference

test/functional/rpc_psbt.py
288 ↗(On Diff #21501)

Remove

296 ↗(On Diff #21501)

Dito

This revision now requires changes to proceed.Jun 18 2020, 10:04

tried to remove parts of the test that do not apply and make it more informative

deadalnix requested changes to this revision.Jun 20 2020, 02:27
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/rpc/rawtransaction.cpp
1658 ↗(On Diff #21531)

dewitnessify

This revision now requires changes to proceed.Jun 20 2020, 02:27

removed additional segwit/bech32 references

This revision is now accepted and ready to land.Jun 23 2020, 07:13