Page MenuHomePhabricator
Differential D6642

[backport#16542 1/4] Return an error from descriptor Parse that gives more information about what failed
ClosedPublic
Actions

Authored by majcosta on Jun 18 2020, 18:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC2abb29db9d5b: [backport#16542 1/4] Return an error from descriptor Parse that gives more…
Summary

https://github.com/bitcoin/bitcoin/pull/16542/commits/c325f619dd071b5489989f645e42cace8eb23fb4

Depends on D6641

Partial backport of Core PR16542

Test Plan
ninja check
ninja
test_runner.py wallet_importmulti

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 18 2020, 18:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 18 2020, 18:27
majcosta requested review of this revision.Jun 18 2020, 18:27
teamcity edited the summary of this revision. (Show Details)Jun 18 2020, 18:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11571: Diff 21533.Jun 18 2020, 18:38
majcosta mentioned this in D6643: [backport#pr16542 2/4] Give more errors for specific failure conditions.Jun 18 2020, 19:40
deadalnix accepted this revision.Jun 18 2020, 23:15
This revision is now accepted and ready to land.Jun 18 2020, 23:15
majcosta added a child revision: D6643: [backport#pr16542 2/4] Give more errors for specific failure conditions.Jun 21 2020, 19:23
Closed by commit rABC2abb29db9d5b: [backport#16542 1/4] Return an error from descriptor Parse that gives more… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJul 1 2020, 15:21
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC2abb29db9d5b: [backport#16542 1/4] Return an error from descriptor Parse that gives more….

Revision Contents
Changeset List

PathSize
src/
rpc/
10 lines
8 lines
script/
2 lines
79 lines
test/
11 lines
wallet/
7 lines
test/
functional/
2 lines

Diff 21926

View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

src/script/descriptor.h

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/test/descriptor_tests.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...