Page MenuHomePhabricator
Differential D6624

[backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT
ClosedPublic
Actions

Authored by majcosta on Jun 17 2020, 17:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3264546a77b3: [backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT
Summary

https://github.com/bitcoin/bitcoin/pull/15427/commits/3135c1a2d2e2fb31bc362c848bd2456d576e408b

Depends on D6616

Partial backport of Core PR15427

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 17 2020, 17:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2020, 17:46
majcosta requested review of this revision.Jun 17 2020, 17:46
teamcity edited the summary of this revision. (Show Details)Jun 17 2020, 17:46

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11546: Diff 21499.Jun 17 2020, 18:00
majcosta added a child revision: D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.Jun 17 2020, 18:19
Fabien accepted this revision.Jun 18 2020, 09:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/psbt.cpp
193 ↗(On Diff #21499)

Remove witness_script

This revision is now accepted and ready to land.Jun 18 2020, 09:59
Closed by commit rABC3264546a77b3: [backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 23 2020, 18:39
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC3264546a77b3: [backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT.

Revision Contents
Changeset List

PathSize
src/
9 lines
23 lines
wallet/
14 lines

Diff 21660

View Options

src/psbt.h

Loading...
View Options

src/psbt.cpp

Loading...
View Options

src/wallet/psbtwallet.cpp

Loading...