Differential D6693

Make sigcheck violation report invaid rather than non standard
ClosedPublic
Actions

Authored by deadalnix on Jun 23 2020, 23:03.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC0c22fdc614fb: Make sigcheck violation report invaid rather than non standard

Summary

As per title. The CValidationState was set improperly.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

invalidsigcheck

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11648
Build 22683: Default Diff Build & Tests	Link to the build
Build 22682: Build without Wallet	Link to the build
Build 22681: Build with clang-10	Link to the build
Build 22680: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 23 2020, 23:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 23 2020, 23:03

deadalnix requested review of this revision.Jun 23 2020, 23:03

Harbormaster completed remote builds in B11648: Diff 21668.Jun 23 2020, 23:14

jasonbcox accepted this revision.Jun 24 2020, 00:13

This revision is now accepted and ready to land.Jun 24 2020, 00:13

Closed by commit rABC0c22fdc614fb: Make sigcheck violation report invaid rather than non standard (authored by deadalnix). · Explain WhyJun 24 2020, 00:51

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0c22fdc614fb: Make sigcheck violation report invaid rather than non standard.

Fabien mentioned this in D6698: [refactor] Add useful-for-dos "reason" field to CValidationState.Jun 24 2020, 08:25

Revision Contents
Changeset List

Path

Size

src/

test/

txvalidationcache_tests.cpp

4 lines

validation.cpp

3 lines

Diff 21668

View Options

src/test/txvalidationcache_tests.cpp