Differential D6708

[refactor] Use Reasons directly instead of DoS codes
ClosedPublic
Actions

Authored by deadalnix on Jun 24 2020, 15:57.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCf0b9e1055c7f: [refactor] Use Reasons directly instead of DoS codes

Summary

This is a partial backport of Core PR15141 : https://github.com/bitcoin/bitcoin/pull/15141/commits/ef54b486d5333dfc85c56e6b933c81735196a25d

Depends on D6707

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 24 2020, 15:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 15:57

deadalnix requested review of this revision.Jun 24 2020, 15:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11665: Diff 21694.Jun 24 2020, 16:11

majcosta accepted this revision.Jun 24 2020, 18:01

This revision is now accepted and ready to land.Jun 24 2020, 18:01

Closed by commit rABCf0b9e1055c7f: [refactor] Use Reasons directly instead of DoS codes (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJun 24 2020, 22:31

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf0b9e1055c7f: [refactor] Use Reasons directly instead of DoS codes.

PiRK mentioned this in D15014: remove unused BlockValidationResult::BLOCK_FINALIZED.Dec 20 2023, 14:25

PiRK mentioned this in rABC7ff3d53435cc: remove unused BlockValidationResult::BLOCK_FINALIZED.Dec 21 2023, 06:53

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

99 lines

Diff 21735

View Options

[refactor] Use Reasons directly instead of DoS codesClosedPublicActions