Paths

Table of Contentst

Differential D6923

[validation] Remove fMissingInputs from AcceptToMemoryPool()
ClosedPublic
Actions

Authored by jasonbcox on Jul 13 2020, 18:28.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC99589edae440: [validation] Remove fMissingInputs from AcceptToMemoryPool()

Summary

Handle this failure in the same way as all other failures: call Invalid()
with the reasons for the failure.

Partial backport of Core PR15921 : https://github.com/bitcoin/bitcoin/pull/15921/commits/3004d5a12d09d94bfc4dee2a8e8f2291996a4aaf

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15921-missing-inputs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11990
Build 23796: Default Diff Build & Tests
Build 23795: Build without Wallet	build-without-wallet
Build 23794: Build with clang-10	build-clang-10
Build 23793: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 13 2020, 18:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 13 2020, 18:28

jasonbcox requested review of this revision.Jul 13 2020, 18:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Jul 13 2020, 18:53

This revision is now accepted and ready to land.Jul 13 2020, 18:53

jasonbcox added a child revision: D6860: Merge #15921: validation: Tidy up ValidationState interface.Jul 13 2020, 23:37

This revision was landed with ongoing or failed builds.Jul 13 2020, 23:39

Closed by commit rABC99589edae440: [validation] Remove fMissingInputs from AcceptToMemoryPool() (authored by John Newbery <john@johnnewbery.com>, committed by jasonbcox). · Explain Why

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC99589edae440: [validation] Remove fMissingInputs from AcceptToMemoryPool().

Revision Contents
Changeset List

Path

Size

src/

bench/

block_assemble.cpp

1 line

consensus/

validation.h

4 lines

net_processing.cpp

12 lines

node/

transaction.cpp

16 lines

rpc/

rawtransaction.cpp

18 lines

test/

txvalidation_tests.cpp

1 line

txvalidationcache_tests.cpp

3 lines

txmempool.cpp

1 line

validation.h

4 lines

validation.cpp

49 lines

test/

functional/

rpc_rawtransaction.py

6 lines

Diff 22234

View Options

src/bench/block_assemble.cpp

View Options

src/consensus/validation.h

View Options

src/net_processing.cpp

View Options

src/node/transaction.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/txvalidation_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/txmempool.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

test/functional/rpc_rawtransaction.py

[validation] Remove fMissingInputs from AcceptToMemoryPool()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22234

src/bench/block_assemble.cpp

src/consensus/validation.h

src/net_processing.cpp

src/node/transaction.cpp

src/rpc/rawtransaction.cpp

src/test/txvalidation_tests.cpp

src/test/txvalidationcache_tests.cpp

src/txmempool.cpp

src/validation.h

src/validation.cpp

test/functional/rpc_rawtransaction.py

[validation] Remove fMissingInputs from AcceptToMemoryPool()
ClosedPublic
Actions

Revision Contents
Changeset List