Page MenuHomePhabricator
Differential D7506

[backport#15931 1/9] Pass block height in Chain::BlockConnected/Chain::BlockDisconnected
ClosedPublic
Actions

Authored by majcosta on Sep 22 2020, 00:56.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCf5619aa4a7b1: [backport#15931 1/9] Pass block height in Chain::BlockConnected/Chain…
Summary

To do so we update CValidationInterface::BlockDisconnect to take a
CBlockIndex pointing to the block being disconnected.

This new parameter will be use in the following commit to establish
wallet height.

https://github.com/bitcoin/bitcoin/pull/15931/commits/10b4729e33f76092bd8cfa06d1a5e0a066436f76

Partial backport of Core PR15931

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 22 2020, 00:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 00:56
majcosta requested review of this revision.Sep 22 2020, 00:56
teamcity edited the summary of this revision. (Show Details)Sep 22 2020, 00:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12835: Diff 23646.Sep 22 2020, 01:07
majcosta added a child revision: D7507: [backport#15931 2/9] Add m_last_block_processed_height field in CWallet.Sep 22 2020, 01:17
deadalnix requested changes to this revision.Sep 22 2020, 01:46
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/validationinterface.cpp
240 ↗(On Diff #23646)

It does looks like you can remove the comment now.

This revision now requires changes to proceed.Sep 22 2020, 01:46
majcosta updated this revision to Diff 23648.Sep 22 2020, 01:52

removed now unnecessary TODO comment

Harbormaster completed remote builds in B12837: Diff 23648.Sep 22 2020, 02:03
deadalnix accepted this revision.Sep 22 2020, 11:40
This revision is now accepted and ready to land.Sep 22 2020, 11:40
Closed by commit rABCf5619aa4a7b1: [backport#15931 1/9] Pass block height in Chain::BlockConnected/Chain… (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhySep 22 2020, 14:55
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCf5619aa4a7b1: [backport#15931 1/9] Pass block height in Chain::BlockConnected/Chain….

Revision Contents
Changeset List

Diff 23669

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/test/validation_block_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/zmq/zmqnotificationinterface.h

Loading...
View Options

src/zmq/zmqnotificationinterface.cpp

Loading...