Page MenuHomePhabricator
Differential D8114

Replace GetSigningProvider with GetSolvingProvider
ClosedPublic
Actions

Authored by deadalnix on Oct 25 2020, 15:29.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC206346fce4db: Replace GetSigningProvider with GetSolvingProvider
Summary

Not all ScriptPubKeyMans will be able to provide private keys,
but pubkeys and scripts should be. So only provide public-only
SigningProviders, i.e. ones that can help with Solving.

Backport of Core PR18115 part [8/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/dc174881ad8498a6905ba282a48077bc5c8037a7

Depends on D8100 and D8102

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.Oct 25 2020, 15:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2020, 15:29
deadalnix requested review of this revision.Oct 25 2020, 15:29
teamcity edited the summary of this revision. (Show Details)Oct 25 2020, 15:29
PiRK accepted this revision.Oct 25 2020, 15:36
This revision is now accepted and ready to land.Oct 25 2020, 15:36
This revision was landed with ongoing or failed builds.Oct 25 2020, 15:40
Closed by commit rABC206346fce4db: Replace GetSigningProvider with GetSolvingProvider (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC206346fce4db: Replace GetSigningProvider with GetSolvingProvider.
Harbormaster completed remote builds in B13667: Diff 25080.Oct 25 2020, 15:48

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
11 lines
wallet/
8 lines
17 lines
2 lines
4 lines
12 lines

Diff 25080

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/scriptpubkeyman.h

Loading...
View Options

src/wallet/scriptpubkeyman.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...