Remove transport protocol knowhow from CNetMessage / net processing
ClosedPublic
Actions

Authored by Fabien on Nov 1 2020, 21:35.

Details

Reviewers

PiRK
jasonbcox

Group Reviewers

Restricted Project

Commits

rABCe692ba5cc55e: Remove transport protocol knowhow from CNetMessage / net processing

Summary

Partial backport 2/7 of core PR16202:
https://github.com/bitcoin/bitcoin/pull/16202/commits/1a5c656c3169ba525f84145d19ce8c64f2cf1efb

Depends on D8222.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16202_part2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13803
Build 27625: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 27624: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 1 2020, 21:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2020, 21:35

Fabien requested review of this revision.Nov 1 2020, 21:35

teamcity edited the summary of this revision. (Show Details)Nov 1 2020, 21:35

Fabien added a child revision: D8224: Use adapter pattern for the network deserializer.Nov 1 2020, 21:39

Harbormaster completed remote builds in B13803: Diff 25336.Nov 1 2020, 21:48

PiRK accepted this revision.Nov 2 2020, 08:28

This revision is now accepted and ready to land.Nov 2 2020, 08:28

jasonbcox accepted this revision.Nov 2 2020, 21:41

Closed by commit rABCe692ba5cc55e: Remove transport protocol knowhow from CNetMessage / net processing (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyNov 3 2020, 10:01

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe692ba5cc55e: Remove transport protocol knowhow from CNetMessage / net processing.

Revision Contents
Changeset List

Path

Size

src/

net.h

2 lines

net.cpp

7 lines

net_processing.cpp

3 lines

Diff 25336

View Options

src/net.h

View Options

src/net.cpp

View Options

Remove transport protocol knowhow from CNetMessage / net processingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25336

src/net.h

src/net.cpp

src/net_processing.cpp

Remove transport protocol knowhow from CNetMessage / net processing
ClosedPublic
Actions

Revision Contents
Changeset List