Force CNetMessage::m_recv to use std::move
ClosedPublic
Actions

Authored by Fabien on Nov 1 2020, 21:43.

Details

Reviewers

PiRK
jasonbcox

Group Reviewers

Restricted Project

Commits

rABCaf5f2e8b2df5: Force CNetMessage::m_recv to use std::move

Summary

Partial backport 4/7 of core PR16202:
https://github.com/bitcoin/bitcoin/pull/16202/commits/b0e10ff4df3d4c70fb172ea8c3128c82e6e368bb

Depends on D8224.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16202_part4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13805
Build 27629: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27628: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 1 2020, 21:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2020, 21:43

Fabien requested review of this revision.Nov 1 2020, 21:43

teamcity edited the summary of this revision. (Show Details)Nov 1 2020, 21:43

Fabien added a child revision: D8226: Remove oversized message detection from log and interface.Nov 1 2020, 21:46

Harbormaster completed remote builds in B13805: Diff 25338.Nov 1 2020, 21:57

PiRK accepted this revision.Nov 2 2020, 08:46

This revision is now accepted and ready to land.Nov 2 2020, 08:46

jasonbcox accepted this revision.Nov 2 2020, 21:48

Closed by commit rABCaf5f2e8b2df5: Force CNetMessage::m_recv to use std::move (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyNov 3 2020, 10:03

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCaf5f2e8b2df5: Force CNetMessage::m_recv to use std::move.

Revision Contents
Changeset List

Path

Size

src/

net.h

2 lines

Diff 25338

View Options

Force CNetMessage::m_recv to use std::moveClosedPublicActions