Differential D8480

refactor: replace CConnman pointers by references in net_processing.cpp
ClosedPublic
Actions

Authored by Fabien on Nov 20 2020, 16:06.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC7ce32e64a0e3: refactor: replace CConnman pointers by references in net_processing.cpp

Summary

This is a follow-up to the recently merged PR #19053, replacing two more
types of one more type of pointer (CConnman) by references to increase
the code quality -- pointers should either check for nullptr or be
replaced by references, and the latter strategy seems to be more
reasonable.

Again, to keep the review burden managable, the changes are kept simple,

    only tackling CConnman* and BanMan* pointers
    only within the net_processing module, i.e. no changes that would
need adaption in other modules
    keeping the names of the variables as they are

Backport of core PR19174.

Depends on D8479.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19174

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14129
Build 28259: Build Diff	build-debug · lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 28258: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 20 2020, 16:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2020, 16:06

Fabien requested review of this revision.Nov 20 2020, 16:06

teamcity edited the summary of this revision. (Show Details)Nov 20 2020, 16:06

Harbormaster completed remote builds in B14129: Diff 25908.Nov 20 2020, 16:13

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: p2p_timeouts.py ======

------- Stdout: -------
2020-11-20T16:11:46.603000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201120_161114/p2p_timeouts_112
2020-11-20T16:11:51.915000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/p2p_timeouts.py", line 89, in run_test
    assert not no_verack_node.is_connected
AssertionError
2020-11-20T16:11:54.592000Z TestFramework (INFO): Stopping nodes
2020-11-20T16:11:55.648000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201120_161114/p2p_timeouts_112
2020-11-20T16:11:55.648000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201120_161114/p2p_timeouts_112/test_framework.log
2020-11-20T16:11:55.648000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201120_161114/p2p_timeouts_112' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_timeouts.py

deadalnix accepted this revision.Nov 21 2020, 00:37

This revision is now accepted and ready to land.Nov 21 2020, 00:37

This revision was landed with ongoing or failed builds.Nov 21 2020, 07:52

Closed by commit rABC7ce32e64a0e3: refactor: replace CConnman pointers by references in net_processing.cpp (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7ce32e64a0e3: refactor: replace CConnman pointers by references in net_processing.cpp.

majcosta mentioned this in D9162: [backport#18861] Do not answer GETDATA for to-be-announced tx.Feb 3 2021, 23:35

majcosta mentioned this in rABCdb81f26de654: [backport#18861] Do not answer GETDATA for to-be-announced tx.Feb 4 2021, 12:46