Differential D8649

Pass bilingual_str argument to AbortNode()
ClosedPublic
Actions

Authored by Fabien on Dec 10 2020, 20:24.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC1ec7ba83469f: Pass bilingual_str argument to AbortNode()

Summary

This PR is a followup of #16224, and it adds bilingual_str type argument
support to the AbortNode() functions.

Backport of core PR18927.

Depends on D8648.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18927

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14375
Build 28725: Build Diff	lint-circular-dependencies · build-clang · build-debug · build-without-wallet · build-clang-tidy · build-diff
Build 28724: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 10 2020, 20:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2020, 20:24

Fabien requested review of this revision.Dec 10 2020, 20:24

teamcity edited the summary of this revision. (Show Details)Dec 10 2020, 20:24

Harbormaster completed remote builds in B14375: Diff 26313.Dec 10 2020, 20:36

Fabien added a child revision: D8650: refactor: Use AbortError in FatalError.Dec 10 2020, 21:01

jasonbcox accepted this revision.Dec 10 2020, 23:44

This revision is now accepted and ready to land.Dec 10 2020, 23:44

Closed by commit rABC1ec7ba83469f: Pass bilingual_str argument to AbortNode() (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyDec 11 2020, 07:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1ec7ba83469f: Pass bilingual_str argument to AbortNode().

PiRK mentioned this in D11349: Move AbortNode to shutdown and fix an error message.Apr 13 2022, 13:05

PiRK mentioned this in rABCd4ff766e57a4: Move AbortNode to shutdown and fix an error message.Apr 27 2022, 10:18

Revision Contents
Changeset List

Path

Size

src/

noui.cpp

4 lines

qt/

11 lines

4 lines

3 lines

42 lines

Diff 26313

View Options

src/noui.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/walletcontroller.cpp

View Options

src/ui_interface.h

View Options

Pass bilingual_str argument to AbortNode()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26313

src/noui.cpp

src/qt/bitcoingui.cpp

src/qt/walletcontroller.cpp

src/ui_interface.h

src/validation.cpp

Pass bilingual_str argument to AbortNode()
ClosedPublic
Actions

Revision Contents
Changeset List