Paths

Table of Contentst

Differential D873

Update clang-format to 4.0
ClosedPublic
Actions

Authored by deadalnix on Jan 3 2018, 21:12.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING86f954aedd3e: Update clang-format to 4.0
rABC86f954aedd3e: Update clang-format to 4.0

Summary

As per title. It seems like mst software out there ship with 4.0 nowadays, and we just released, so it's a good time to upgrade.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

clangfmt4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1506
Build 1506: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 3 2018, 21:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2018, 21:12

schancel accepted this revision.Jan 4 2018, 13:54

This revision is now accepted and ready to land.Jan 4 2018, 13:54

schancel requested changes to this revision.Jan 4 2018, 13:57

This revision now requires changes to proceed.Jan 4 2018, 13:57

brew only has clang-format@3.8 and clang-format version 6.0.0 (tags/google/stable/2017-11-14). There's substantial changes on 6.0.0 from this diff.

Backport some formating from more recent version of clang-format

Harbormaster completed remote builds in B1506: Diff 2336.Jan 4 2018, 14:28

Is this now clang-format 6 or something? I don't understand the comment.

schancel accepted this revision.Jan 7 2018, 04:17

This revision is now accepted and ready to land.Jan 7 2018, 04:17

Closed by commit rABC86f954aedd3e: Update clang-format to 4.0 (authored by deadalnix). · Explain WhyJan 7 2018, 14:53

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..Jul 10 2019, 22:06

Revision Contents
Changeset List

Path

Size

src/

addrman.cpp

4 lines

bench/

bench.h

2 lines

cashaddrenc.cpp

2 lines

checkqueue.h

4 lines

compat/

glibc_sanity.cpp

2 lines

glibcxx_sanity.cpp

2 lines

crypto/

ctaes/

8 lines

8 lines

16 lines

2 lines

2 lines

1 line

20 lines

2 lines

19 lines

104 lines

2 lines

2 lines

8 lines

qt/

bitcoinamountfield.h

2 lines

coincontroldialog.cpp

7 lines

intro.cpp

7 lines

openuridialog.cpp

4 lines

platformstyle.cpp

2 lines

receiverequestdialog.cpp

20 lines

rpcconsole.cpp

4 lines

test/

2 lines

1 line

2 lines

10 lines

6 lines

transactiontablemodel.cpp

14 lines

transactionview.cpp

7 lines

walletmodel.cpp

5 lines

rpc/

9 lines

11 lines

18 lines

4 lines

5 lines

script/

2 lines

6 lines

2 lines

14 lines

seeder/

bitcoin.cpp

6 lines

main.cpp

5 lines

test/

cashaddrenc_tests.cpp

2 lines

2 lines

12 lines

2 lines

2 lines

4 lines

56 lines

2 lines

policyestimator_tests.cpp

35 lines

pow_tests.cpp

2 lines

scheduler_tests.cpp

2 lines

script_P2SH_tests.cpp

2 lines

22 lines

2 lines

4 lines

2 lines

transaction_tests.cpp

4 lines

2 lines

2 lines

2 lines

4 lines

4 lines

5 lines

13 lines

2 lines

wallet/

rpcdump.cpp

5 lines

rpcwallet.cpp

9 lines

test/

crypto_tests.cpp

4 lines

walletdb_tests.cpp

2 lines

wallet.cpp

4 lines

Diff 2336

View Options

src/addrman.cpp

View Options

src/bench/bench.h

View Options

src/cashaddrenc.cpp

View Options

src/checkqueue.h

View Options

src/compat/glibc_sanity.cpp

View Options

src/compat/glibcxx_sanity.cpp

View Options

src/crypto/ctaes/ctaes.c

View Options

src/crypto/ctaes/test.c

View Options

src/cuckoocache.h

View Options

src/dbwrapper.h

View Options

src/dbwrapper.cpp

View Options

src/httprpc.cpp

View Options

src/init.cpp

View Options

src/memusage.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/protocol.h

View Options

src/protocol.cpp

View Options

src/pubkey.cpp

View Options

src/qt/bitcoinamountfield.h

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/intro.cpp

View Options

src/qt/openuridialog.cpp

View Options

src/qt/platformstyle.cpp

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/qt/test/guiutiltests.cpp

View Options

src/qt/test/rpcnestedtests.cpp

View Options

src/qt/test/uritests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.h

View Options

src/qt/transactiontablemodel.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/server.h

View Options

src/scheduler.cpp

View Options

src/script/bitcoinconsensus.cpp

View Options

src/script/script.cpp

View Options

src/script/sigcache.cpp

View Options

src/script/standard.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/seeder/main.cpp

View Options

src/test/cashaddrenc_tests.cpp

View Options

src/test/config_tests.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/dstencode_tests.cpp

View Options

src/test/hash_tests.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/net_tests.cpp

View Options

src/test/policyestimator_tests.cpp

View Options

src/test/pow_tests.cpp

View Options

src/test/scheduler_tests.cpp

View Options

src/test/script_P2SH_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/serialize_tests.cpp

View Options

src/test/sigopcount_tests.cpp

View Options

src/test/timedata_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/uint256_tests.cpp

View Options

src/test/undo_tests.cpp

View Options

src/test/validation_tests.cpp

View Options

src/tinyformat.h

View Options

src/txdb.cpp

View Options

src/txmempool.h

View Options

src/validation.cpp

View Options

src/versionbits.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/crypto_tests.cpp

View Options

src/wallet/test/walletdb_tests.cpp

View Options

Update clang-format to 4.0ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2336

src/addrman.cpp

src/bench/bench.h

src/cashaddrenc.cpp

src/checkqueue.h

src/compat/glibc_sanity.cpp

src/compat/glibcxx_sanity.cpp

src/crypto/ctaes/ctaes.c

src/crypto/ctaes/test.c

src/cuckoocache.h

src/dbwrapper.h

src/dbwrapper.cpp

src/httprpc.cpp

src/init.cpp

src/memusage.h

src/net.cpp

src/net_processing.cpp

src/protocol.h

src/protocol.cpp

src/pubkey.cpp

src/qt/bitcoinamountfield.h

src/qt/coincontroldialog.cpp

src/qt/intro.cpp

src/qt/openuridialog.cpp

src/qt/platformstyle.cpp

src/qt/receiverequestdialog.cpp

src/qt/rpcconsole.cpp

src/qt/test/guiutiltests.cpp

src/qt/test/rpcnestedtests.cpp

src/qt/test/uritests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.h

src/qt/transactiontablemodel.cpp

src/qt/transactionview.cpp

src/qt/walletmodel.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/rpc/server.h

src/scheduler.cpp

src/script/bitcoinconsensus.cpp

src/script/script.cpp

src/script/sigcache.cpp

src/script/standard.cpp

src/seeder/bitcoin.cpp

src/seeder/main.cpp

src/test/cashaddrenc_tests.cpp

src/test/config_tests.cpp

src/test/crypto_tests.cpp

src/test/dstencode_tests.cpp

src/test/hash_tests.cpp

src/test/mempool_tests.cpp

src/test/miner_tests.cpp

src/test/net_tests.cpp

src/test/policyestimator_tests.cpp

src/test/pow_tests.cpp

src/test/scheduler_tests.cpp

src/test/script_P2SH_tests.cpp

src/test/script_tests.cpp

src/test/serialize_tests.cpp

src/test/sigopcount_tests.cpp

src/test/timedata_tests.cpp

src/test/transaction_tests.cpp

src/test/uint256_tests.cpp

src/test/undo_tests.cpp

src/test/validation_tests.cpp

src/tinyformat.h

src/txdb.cpp

src/txmempool.h

src/validation.cpp

src/versionbits.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/crypto_tests.cpp

src/wallet/test/walletdb_tests.cpp

Update clang-format to 4.0
ClosedPublic
Actions

Revision Contents
Changeset List