Page MenuHomePhabricator

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
ClosedPublic

Authored by deadalnix on Tue, Jul 9, 19:49.

Details

Reviewers
Fabien
jasonbcox
markblundeberg
nakihito
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
Summary

5a9b508 [trivial] Add end of namespace comments (practicalswift)

Tree-SHA512: 92b0fcae4d1d3f4da9e97569ae84ef2d6e09625a5815cd0e5f0eb6dd2ecba9852fa85c184c5ae9de5117050330ce995e9867b451fa8cd5512169025990541a2b

Backport of Core PR9544
https://github.com/bitcoin/bitcoin/pull/9544/files

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Jul 9, 19:49
Owners added a reviewer: Restricted Owners Package.Tue, Jul 9, 19:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 9, 19:49
nakihito planned changes to this revision.Tue, Jul 9, 19:49
nakihito requested review of this revision.Wed, Jul 10, 22:06

base58.cpp change wes made in D624 and then the code was moved to a different file in D3577.
The majority of other changes were made in D873.

deadalnix requested changes to this revision.Wed, Jul 10, 23:56

There is a tool that can do this automatically and exaustively. Use it.

This revision now requires changes to proceed.Wed, Jul 10, 23:56
deadalnix commandeered this revision.Sun, Jul 14, 17:49
deadalnix edited reviewers, added: nakihito; removed: deadalnix.
deadalnix updated this revision to Diff 10288.Sun, Jul 14, 17:53

Update cland-format to enforce the new style

nakihito accepted this revision.Mon, Jul 15, 22:39
jasonbcox accepted this revision.Tue, Jul 16, 03:01
This revision is now accepted and ready to land.Tue, Jul 16, 03:01