Differential D8762

[backport#16658] validation: Rename CheckInputs to CheckInputScripts
ClosedPublic
Actions

Authored by majcosta on Dec 29 2020, 19:54.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC925120cac2cb: [backport#16658] validation: Rename CheckInputs to CheckInputScripts

Summary

3bd8db80d8d335ab63ece4f110b0fadd562e80b7 [validation] fix comments in CheckInputScripts() (John Newbery)
6f6465cefcd599c89c00f7b51f42a4b87a5ffb0b scripted-diff: [validation] Rename CheckInputs to CheckInputScripts (John Newbery)

Pull request description:

CheckInputs() used to check no double spends, scripts & sigs and amounts. Since
832e074, the double spend and amount checks
have been moved to CheckTxInputs(), and CheckInputs() now just validates
input scripts. Rename the function to CheckInputScripts().

Also fix incorrect comments.

Backport of Core PR16658

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16658

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14532
Build 29026: Build Diff	lint-circular-dependencies · build-clang-tidy · build-clang · build-debug · build-without-wallet · build-diff
Build 29025: arc lint + arc unit

Event Timeline

majcosta created this revision.Dec 29 2020, 19:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 29 2020, 19:54

majcosta requested review of this revision.Dec 29 2020, 19:54

teamcity edited the summary of this revision. (Show Details)Dec 29 2020, 19:54

Harbormaster completed remote builds in B14532: Diff 26581.Dec 29 2020, 20:09

What about the integration tests?

This revision now requires changes to proceed.Dec 29 2020, 23:26

it looks like D3878 and D3875 diverged from Core so that the tests don't rely on whether "CheckInputs" or "CheckInputScripts" gets printed to the debug log

deadalnix accepted this revision.Jan 13 2021, 14:21

This revision is now accepted and ready to land.Jan 13 2021, 14:21

Closed by commit rABC925120cac2cb: [backport#16658] validation: Rename CheckInputs to CheckInputScripts (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJan 13 2021, 14:44

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC925120cac2cb: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.