Page MenuHomePhabricator

[CASHTAB] Update the jest dependency
ClosedPublic

Authored by Fabien on Thu, Jan 7, 14:47.

Details

Reviewers
deadalnix
majcosta
Group Reviewers
Restricted Project
Commits
rABC82da5b3491b1: [CASHTAB] Update the jest dependency
Summary

Update jest to the latest version. This will allow for creating
coverage report files as needed, which is not supported with current
version.
Note that the collectCoverageFrom regex exclusion has been removed. It
was not matching any file and is very likely broken:
https://github.com/facebook/jest/issues/9464, so it's better to no rely
on it.
The coverage behavior seems to change quite a lot, because it takes into
acount the files with 0 coverage which were previously not accounted
for.

Test Plan
npm install
npm test
npm run test:coverage

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested review of this revision.Thu, Jan 7, 14:47
deadalnix requested changes to this revision.Thu, Jan 7, 15:39
deadalnix added a subscriber: deadalnix.

If you need --legacy-peer-deps you have regressed something.

This revision now requires changes to proceed.Thu, Jan 7, 15:39
Fabien requested review of this revision.Thu, Jan 7, 16:10
Fabien edited the test plan for this revision. (Show Details)
Fabien added a subscriber: josephroyking.

I got this from the README, I did not introduce it for this diff. I tried without and it seems to run just fine, it's probably no longer needed @josephroyking ?
I updated the test plan.

This revision is now accepted and ready to land.Thu, Jan 7, 18:57
This revision was automatically updated to reflect the committed changes.