[CASHTAB] Update the jest dependency
ClosedPublic
Actions

Authored by Fabien on Jan 7 2021, 14:47.

Details

Reviewers

deadalnix
majcosta

Group Reviewers

Restricted Project

Commits

rABC82da5b3491b1: [CASHTAB] Update the jest dependency

Summary

Update jest to the latest version. This will allow for creating
coverage report files as needed, which is not supported with current
version.
Note that the collectCoverageFrom regex exclusion has been removed. It
was not matching any file and is very likely broken:
https://github.com/facebook/jest/issues/9464, so it's better to no rely
on it.
The coverage behavior seems to change quite a lot, because it takes into
acount the files with 0 coverage which were previously not accounted
for.

Test Plan

npm install
npm test
npm run test:coverage

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 7 2021, 14:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2021, 14:47

Fabien requested review of this revision.Jan 7 2021, 14:47

Harbormaster completed remote builds in B14635: Diff 26739.Jan 7 2021, 14:48

Fabien edited the test plan for this revision. (Show Details)Jan 7 2021, 15:36

If you need --legacy-peer-deps you have regressed something.

This revision now requires changes to proceed.Jan 7 2021, 15:39

Fabien added a child revision: D8832: [CI] Generate Junit output for the cashtab tests.Jan 7 2021, 15:41

majcosta accepted this revision.Jan 7 2021, 15:51

I got this from the README, I did not introduce it for this diff. I tried without and it seems to run just fine, it's probably no longer needed @josephroyking ?
I updated the test plan.

no longer needed

deadalnix accepted this revision.Jan 7 2021, 18:57

This revision is now accepted and ready to land.Jan 7 2021, 18:57

Closed by commit rABC82da5b3491b1: [CASHTAB] Update the jest dependency (authored by Fabien). · Explain WhyJan 7 2021, 20:09

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC82da5b3491b1: [CASHTAB] Update the jest dependency.