test: Report InitBlockIndex result
ClosedPublic
Actions

Authored by deadalnix on Jan 6 2018, 13:09.

Details

Reviewers

schancel
dagurval

Group Reviewers

Restricted Project

Commits

rSTAGING419c76905010: test: Report InitBlockIndex result
rABC419c76905010: test: Report InitBlockIndex result

Summary

If InitBlockIndex fails, then it will segfault later. Same for the later
ActivateBestChain. BOOST_REQUIRE the result, so that an error will be
reported and the test case aborted.

Backport of core's PR9904

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

initfail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1528
Build 1528: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 6 2018, 13:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2018, 13:09

Harbormaster completed remote builds in B1528: Diff 2377.Jan 6 2018, 13:09

deadalnix added a child revision: D906: Add basic Qt wallet test.Jan 6 2018, 17:05

dagurval accepted this revision.Jan 7 2018, 22:25

This revision is now accepted and ready to land.Jan 7 2018, 22:25

Closed by commit rABC419c76905010: test: Report InitBlockIndex result (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by deadalnix). · Explain WhyJan 7 2018, 22:40

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

test_bitcoin.cpp

4 lines

Diff 2377

View Options

test: Report InitBlockIndex resultClosedPublicActions