Page MenuHomePhabricator

Make Hash[160] consume range-like objects
ClosedPublic

Authored by Fabien on Feb 3 2021, 17:03.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCd0c313ae912b: Make Hash[160] consume range-like objects
Summary

Completes backport (8/8) of core PR19326:
https://github.com/bitcoin/bitcoin/pull/19326/commits/77c507358bda9bd6c496f33e0f4418c0603bb08d

Depends on D9156.

There is a missing dependency for the walletdb.cpp change for which I
left a comment to make the later backport easier.
This diff also contains a few changes which are specific to our repo.

Test Plan
ninja all check-all

Event Timeline

Fabien requested review of this revision.Feb 3 2021, 17:03
majcosta requested changes to this revision.Feb 3 2021, 20:47
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/seeder/bitcoin.cpp
157–158

why is this here?

src/wallet/walletdb.cpp
133–135
444–446
This revision now requires changes to proceed.Feb 3 2021, 20:47
src/seeder/bitcoin.cpp
157–158

whoops!

Remove commented code line, rebase on top of D9156.

This revision is now accepted and ready to land.Feb 4 2021, 12:46