Page MenuHomePhabricator
Differential D9154

Make Hash[160] consume range-like objects
ClosedPublic
Actions

Authored by Fabien on Feb 3 2021, 17:03.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCd0c313ae912b: Make Hash[160] consume range-like objects
Summary

Completes backport (8/8) of core PR19326:
https://github.com/bitcoin/bitcoin/pull/19326/commits/77c507358bda9bd6c496f33e0f4418c0603bb08d

Depends on D9156.

There is a missing dependency for the walletdb.cpp change for which I
left a comment to make the later backport easier.
This diff also contains a few changes which are specific to our repo.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Feb 3 2021, 17:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2021, 17:03
Fabien requested review of this revision.Feb 3 2021, 17:03
teamcity edited the summary of this revision. (Show Details)Feb 3 2021, 17:04
Harbormaster completed remote builds in B15105: Diff 27519.Feb 3 2021, 18:09
majcosta requested changes to this revision.Feb 3 2021, 20:47
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/seeder/bitcoin.cpp
157–158

why is this here?

src/wallet/walletdb.cpp
133–135

D9156

444–446

D9156

This revision now requires changes to proceed.Feb 3 2021, 20:47
Fabien added inline comments.Feb 4 2021, 08:37
src/seeder/bitcoin.cpp
157–158

whoops!

Fabien edited the summary of this revision. (Show Details)Feb 4 2021, 08:59
Fabien added a parent revision: D9156: [backport#16946] wallet: include a checksum of encrypted private keys.
Fabien updated this revision to Diff 27537.Feb 4 2021, 09:02

Remove commented code line, rebase on top of D9156.

Harbormaster completed remote builds in B15115: Diff 27537.Feb 4 2021, 09:37
majcosta accepted this revision.Feb 4 2021, 12:46
This revision is now accepted and ready to land.Feb 4 2021, 12:46
Closed by commit rABCd0c313ae912b: Make Hash[160] consume range-like objects (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyFeb 4 2021, 20:01
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd0c313ae912b: Make Hash[160] consume range-like objects.

Revision Contents
Changeset List

PathSize
src/
4 lines
37 lines
4 lines
2 lines
2 lines
6 lines
script/
6 lines
seeder/
4 lines
test/
7 lines
test/
fuzz/
3 lines
2 lines
8 lines
7 lines
4 lines
4 lines
5 lines
wallet/
18 lines

Diff 27519

View Options

src/base58.cpp

Loading...
View Options

src/hash.h

Loading...
View Options

src/merkleblock.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/netaddress.cpp

Loading...
View Options

src/pubkey.h

Loading...
View Options

src/script/standard.cpp

Loading...
View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/seeder/test/message_writer_tests.cpp

Loading...
View Options

src/test/fuzz/crypto.cpp

Loading...
View Options

src/test/fuzz/key.cpp

Loading...
View Options

src/test/key_tests.cpp

Loading...
View Options

src/test/merkle_tests.cpp

Loading...
View Options

src/test/serialize_tests.cpp

Loading...
View Options

src/test/sigcache_tests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...