Page MenuHomePhabricator
Differential D932

Replace nHashType with SigHashType in script_tests.cpp
ClosedPublic
Actions

Authored by jasonbcox on Jan 11 2018, 19:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGd7550fa5d980: Replace nHashType with SigHashType in script_tests.cpp
rABCd7550fa5d980: Replace nHashType with SigHashType in script_tests.cpp
Summary

Continuing work on T61 (almost there!).

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pushsig
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1574
Build 1574: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 11 2018, 19:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2018, 19:05
deadalnix requested changes to this revision.Jan 11 2018, 19:24

Only style change. We bumped clang format to 4.0 recently.

src/test/script_tests.cpp
1062

revert

1406

dito

This revision now requires changes to proceed.Jan 11 2018, 19:24
jasonbcox updated this revision to Diff 2455.Jan 11 2018, 20:04

Reverted linting

jasonbcox marked 2 inline comments as done.Jan 11 2018, 20:04
deadalnix accepted this revision.Jan 12 2018, 00:18
This revision is now accepted and ready to land.Jan 12 2018, 00:18
Closed by commit rABCd7550fa5d980: Replace nHashType with SigHashType in script_tests.cpp (authored by jasonbcox). · Explain WhyJan 12 2018, 06:29
This revision was automatically updated to reflect the committed changes.
matra774 mentioned this in T206: Refactor script_tests.cpp::PushSig() to have default SigHashType param.Feb 18 2018, 13:42

Revision Contents
Changeset List

PathSize
src/
test/
113 lines

Diff 2452

View Options

src/test/script_tests.cpp

Loading...