Differential D9504

[net processing] Change AlreadyHaveBlock() to take block_hash argument
ClosedPublic
Actions

Authored by Fabien on May 12 2021, 13:33.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC216399a4b420: [net processing] Change AlreadyHaveBlock() to take block_hash argument

Summary

Partial backport of core#19610:
https://github.com/bitcoin/bitcoin/pull/19610/commits/5fdfb80b861e0de3fcf8a57163b3f52af4b2df3b

Depends on D9503.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19610_p4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15691
Build 31286: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-debug · build-clang-tidy
Build 31285: arc lint + arc unit

Event Timeline

Fabien created this revision.May 12 2021, 13:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2021, 13:33

Fabien requested review of this revision.May 12 2021, 13:33

teamcity edited the summary of this revision. (Show Details)May 12 2021, 13:33

Harbormaster completed remote builds in B15691: Diff 28430.May 12 2021, 13:47

Fabien added a child revision: D9505: [net processing] Change AlreadyHaveTx() to take a GenTxid.May 12 2021, 13:47

majcosta accepted this revision.May 12 2021, 14:41

This revision is now accepted and ready to land.May 12 2021, 14:41

Closed by commit rABC216399a4b420: [net processing] Change AlreadyHaveBlock() to take block_hash argument (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyMay 12 2021, 19:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC216399a4b420: [net processing] Change AlreadyHaveBlock() to take block_hash argument.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

6 lines

Diff 28430

View Options

[net processing] Change AlreadyHaveBlock() to take block_hash argumentClosedPublicActions