Differential D9505

[net processing] Change AlreadyHaveTx() to take a GenTxid
ClosedPublic
Actions

Authored by Fabien on May 12 2021, 13:47.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC2960f55f4488: [net processing] Change AlreadyHaveTx() to take a GenTxid

Summary

Partial backport if core#19610:
https://github.com/bitcoin/bitcoin/pull/19610/commits/acd66421671e42a58e8e067868e1ab86268e3231

Depends on D9504.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19610_p5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15692
Build 31288: Build Diff	build-clang · build-without-wallet · lint-circular-dependencies · build-debug · build-clang-tidy · build-diff
Build 31287: arc lint + arc unit

Event Timeline

Fabien created this revision.May 12 2021, 13:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2021, 13:47

Fabien requested review of this revision.May 12 2021, 13:47

teamcity edited the summary of this revision. (Show Details)May 12 2021, 13:47

Harbormaster completed remote builds in B15692: Diff 28431.May 12 2021, 13:56

Fabien added a child revision: D9506: p2p: use CInv block message helpers in net_processing.cpp.May 12 2021, 14:00

majcosta accepted this revision.May 12 2021, 14:43

This revision is now accepted and ready to land.May 12 2021, 14:43

Closed by commit rABC2960f55f4488: [net processing] Change AlreadyHaveTx() to take a GenTxid (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyMay 12 2021, 19:10

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2960f55f4488: [net processing] Change AlreadyHaveTx() to take a GenTxid.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

13 lines

Diff 28431

View Options

[net processing] Change AlreadyHaveTx() to take a GenTxidClosedPublicActions