Differential D9592

Move the getdata content flush and logging to a lambda
ClosedPublic
Actions

Authored by Fabien on May 26 2021, 20:10.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCf6ce5cf20243: Move the getdata content flush and logging to a lambda

Summary

This is a little refactor of the code which improves readability and can
be leveraged when introducing the proof inventory type.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

addgetdatandmaybeflush

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15822
Build 31544: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 31543: arc lint + arc unit

Event Timeline

Fabien created this revision.May 26 2021, 20:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2021, 20:10

Fabien requested review of this revision.May 26 2021, 20:10

Fabien added a child revision: D9593: Split cs_main lock when sending getdata between inv types.May 26 2021, 20:19

Harbormaster completed remote builds in B15822: Diff 28626.May 26 2021, 20:22

deadalnix accepted this revision.May 26 2021, 21:01

deadalnix edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.May 26 2021, 21:02

Closed by commit rABCf6ce5cf20243: Move the getdata content flush and logging to a lambda (authored by Fabien). · Explain WhyMay 27 2021, 08:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf6ce5cf20243: Move the getdata content flush and logging to a lambda.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

21 lines

Diff 28626

View Options

Move the getdata content flush and logging to a lambdaClosedPublicActions