Page MenuHomePhabricator
Differential D972

Wait for connection to open in bip9-softforks.py
ClosedPublic
Actions

Authored by matiu on Jan 17 2018, 15:51.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING480e057fe351: Wait for connection to open in bip9-softforks.py
rABC480e057fe351: Wait for connection to open in bip9-softforks.py
Summary

bip9-sofforks.py stop-starts the bitcoind node twice during the test
run, but it doesn't wait for the connection from mininode to open before
continuing with the test. This leads to race conditions where the test
can fail getblocktemplate() because it has no p2p connections.

PR:https://github.com/bitcoin/bitcoin/commit/1f3d78b4e099f22b03ffeec9e91c02de81430702

Solves: T144

Test Plan

./test/functional/test_runner.py bip9-softforks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bug/Wait-for-connection-bip9-softforks.py
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1647
Build 1647: arc lint + arc unit

Event Timeline

matiu created this revision.Jan 17 2018, 15:51
Owners added a reviewer: Restricted Owners Package.Jan 17 2018, 15:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2018, 15:51
teamcity added a subscriber: teamcity.Jan 17 2018, 16:05

This revision has failed testing.

deadalnix added a subscriber: deadalnix.Jan 17 2018, 16:47

That was on my TODO list, but it seems like the build is failing. Can you make sure it passes, maybe rebase and update the diff ?

matiu updated this revision to Diff 2562.Jan 17 2018, 17:05

Rebased to current master.

matiu added a comment.Jan 17 2018, 17:19
In D972#17470, @deadalnix wrote:

That was on my TODO list, but it seems like the build is failing. Can you make sure it passes, maybe rebase and update the diff ?

Sure, I just rebased to master. If it fails, I will keep trying.

teamcity added a comment.Jan 17 2018, 17:26

This revision has failed testing.

matiu updated this revision to Diff 2567.EditedJan 17 2018, 19:33

Adds changes in D969 to fix tests. Please note what with this changes, config.ini in zmq_test and test_runner match the ones at https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_runner.py#L204

matiu updated this revision to Diff 2568.Jan 17 2018, 20:04
This comment was removed by matiu.
matiu added a comment.Jan 17 2018, 22:14

Tests seem to be passing with the latest update (Diff id 2568):

https://build.bitcoinabc.org/viewLog.html?buildId=773&tab=buildResultsDiv&buildTypeId=BitcoinABC_BitcoinAbcStaging

deadalnix accepted this revision.Jan 18 2018, 00:07
This revision is now accepted and ready to land.Jan 18 2018, 00:07
matiu mentioned this in D979: Make forknotify.py more robust.Jan 18 2018, 03:54
deadalnix added a child revision: D982: [tests] Functional tests call self.start_node(s) and self.stop_node(s).Jan 19 2018, 01:47
Closed by commit rABC480e057fe351: Wait for connection to open in bip9-softforks.py (authored by John Newbery <john@johnnewbery.com>, committed by matiu). · Explain WhyJan 19 2018, 15:57
This revision was automatically updated to reflect the committed changes.
matiu mentioned this in rABCf42bb363128c: Make forknotify.py more robust.
schancel mentioned this in T144: Backport for PR 10072: Remove sources of unreliablility in extended functional tests.Jan 20 2018, 20:10
matiu mentioned this in rSTAGINGf42bb363128c: Make forknotify.py more robust.Mar 1 2018, 23:42

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
2 lines

Diff 2567

View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/zmq_test.py

Loading...