Page MenuHomePhabricator

Wait for connection to open in bip9-softforks.py
ClosedPublic

Authored by matiu on Jan 17 2018, 15:51.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING480e057fe351: Wait for connection to open in bip9-softforks.py
rABC480e057fe351: Wait for connection to open in bip9-softforks.py
Summary

bip9-sofforks.py stop-starts the bitcoind node twice during the test
run, but it doesn't wait for the connection from mininode to open before
continuing with the test. This leads to race conditions where the test
can fail getblocktemplate() because it has no p2p connections.

PR:https://github.com/bitcoin/bitcoin/commit/1f3d78b4e099f22b03ffeec9e91c02de81430702

Solves: T144

Test Plan

./test/functional/test_runner.py bip9-softforks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bug/Wait-for-connection-bip9-softforks.py
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1648
Build 1648: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jan 17 2018, 15:51

That was on my TODO list, but it seems like the build is failing. Can you make sure it passes, maybe rebase and update the diff ?

Rebased to current master.

That was on my TODO list, but it seems like the build is failing. Can you make sure it passes, maybe rebase and update the diff ?

Sure, I just rebased to master. If it fails, I will keep trying.

Adds changes in D969 to fix tests. Please note what with this changes, config.ini in zmq_test and test_runner match the ones at https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_runner.py#L204

This comment was removed by matiu.
This revision is now accepted and ready to land.Jan 18 2018, 00:07
This revision was automatically updated to reflect the committed changes.