Split key_io (address/key encodings) off from base58
ClosedPublic
Actions

Authored by deadalnix on Jul 7 2019, 14:38.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8a7143e1c26e: Split key_io (address/key encodings) off from base58
rABC8a7143e1c26e: Split key_io (address/key encodings) off from base58

Summary

This is a partial backport of Core PR11372 : https://github.com/bitcoin/bitcoin/pull/11372/commits/119b0f85e2c8b9729228aad5d946144d57ad0f5b

It was altered to support CashAddr.

Depends on D3573 and D3576

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

keyio

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6705
Build 11457: Bitcoin ABC Buildbot (legacy)
Build 11456: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 7 2019, 14:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 14:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6705: Diff 10050.Jul 7 2019, 14:46

deadalnix added a child revision: D3578: Split off key_io_tests from base58_tests.Jul 7 2019, 14:46

markblundeberg accepted this revision.Jul 8 2019, 01:12

This revision is now accepted and ready to land.Jul 8 2019, 01:12

Closed by commit rABC8a7143e1c26e: Split key_io (address/key encodings) off from base58 (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJul 8 2019, 12:28

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC8a7143e1c26e: Split key_io (address/key encodings) off from base58.

nakihito mentioned this in D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..Jul 10 2019, 22:06

deadalnix added a commit: rSTAGING8a7143e1c26e: Split key_io (address/key encodings) off from base58.Sep 19 2019, 01:02

Revision Contents
Changeset List

Path

Size

src/

2 lines

4 lines

23 lines

148 lines

3 lines

2 lines

2 lines

36 lines

	key_io.cpp
	base58.cpp

194 lines

qt/

addresstablemodel.cpp

2 lines

bitcoinaddressvalidator.cpp

3 lines

coincontroldialog.cpp

3 lines

guiutil.cpp

2 lines

paymentrequestplus.h

3 lines

paymentrequestplus.cpp

1 line

paymentserver.cpp

2 lines

sendcoinsdialog.cpp

3 lines

signverifymessagedialog.cpp

2 lines

test/

guiutiltests.cpp

2 lines

paymentservertests.cpp

1 line

wallettests.cpp

2 lines

transactiondesc.cpp

2 lines

transactionrecord.cpp

4 lines

walletmodel.cpp

2 lines

rpc/

2 lines

3 lines

3 lines

2 lines

3 lines

test/

2 lines

2 lines

2 lines

2 lines

4 lines

2 lines

3 lines

wallet/

3 lines

2 lines

2 lines

4 lines

Diff 10050

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/base58.h

View Options

src/base58.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/core_write.cpp

View Options

src/dstencode.h

View Options

src/dstencode.cpp

View Options

src/httprpc.cpp

View Options

src/key_io.h

View Options

src/key_io.cpp

View Options

src/qt/addresstablemodel.cpp

View Options

src/qt/bitcoinaddressvalidator.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/paymentrequestplus.h

View Options

src/qt/paymentrequestplus.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/qt/test/guiutiltests.cpp

View Options

src/qt/test/paymentservertests.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/server.cpp

View Options

src/rpc/util.cpp

View Options

src/test/base58_tests.cpp

View Options

src/test/bip32_tests.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/dstencode_tests.cpp

View Options

src/test/key_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/sigcache_tests.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.cpp

View Options

Split key_io (address/key encodings) off from base58ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10050

src/CMakeLists.txt

src/Makefile.am

src/base58.h

src/base58.cpp

src/bitcoin-tx.cpp

src/core_write.cpp

src/dstencode.h

src/dstencode.cpp

src/httprpc.cpp

src/key_io.h

src/key_io.cpp

src/qt/addresstablemodel.cpp

src/qt/bitcoinaddressvalidator.cpp

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/paymentrequestplus.h

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.cpp

src/qt/sendcoinsdialog.cpp

src/qt/signverifymessagedialog.cpp

src/qt/test/guiutiltests.cpp

src/qt/test/paymentservertests.cpp

src/qt/test/wallettests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/walletmodel.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/rawtransaction.cpp

src/rpc/server.cpp

src/rpc/util.cpp

src/test/base58_tests.cpp

src/test/bip32_tests.cpp

src/test/bloom_tests.cpp

src/test/dstencode_tests.cpp

src/test/key_tests.cpp

src/test/rpc_tests.cpp

src/test/sigcache_tests.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

Split key_io (address/key encodings) off from base58
ClosedPublic
Actions

Revision Contents
Changeset List