Page MenuHomePhabricator
Differential D3626

[refactor multisig] separate nullfail from stack cleanup
ClosedPublic
Actions

Authored by markblundeberg on Jul 10 2019, 01:38.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING10b29ca11538: [refactor multisig] separate nullfail from stack cleanup
rABC10b29ca11538: [refactor multisig] separate nullfail from stack cleanup
Summary

Currently, some rule checks are integrated into the stack cleanup
process, resulting in some obfuscated-looking behaviour.

This moves the stack cleanup to the very end, once all operations
have completed, including nullfail and the dummy element check.

Depends on D3673

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jul 10 2019, 01:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 01:38
teamcity added a comment.Jul 10 2019, 01:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2019, 01:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6785: Diff 10179.Jul 10 2019, 01:44
deadalnix added inline comments.Jul 10 2019, 02:32
src/script/interpreter.cpp
1081 ↗(On Diff #10179)

That guy should probably be moved up front. You wouldn't have to modify it here if you do it first.

markblundeberg planned changes to this revision.Jul 10 2019, 15:49
markblundeberg updated this revision to Diff 10285.Jul 14 2019, 00:43
markblundeberg edited the summary of this revision. (Show Details)
markblundeberg added a parent revision: D3673: [refactor multisig] move nulldummy check to front.

reworked parents

teamcity added a comment.Jul 14 2019, 00:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg removed a parent revision: D3625: [refactor multisig] make const values up front.Jul 14 2019, 00:44
Harbormaster completed remote builds in B6855: Diff 10285.Jul 14 2019, 00:49
teamcity added a comment.Jul 14 2019, 00:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jul 14 2019, 17:06
This revision is now accepted and ready to land.Jul 14 2019, 17:06
Closed by commit rABC10b29ca11538: [refactor multisig] separate nullfail from stack cleanup (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 15 2019, 00:53
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC10b29ca11538: [refactor multisig] separate nullfail from stack cleanup.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING10b29ca11538: [refactor multisig] separate nullfail from stack cleanup.Sep 19 2019, 01:15

Revision Contents
Changeset List

PathSize
src/
script/
28 lines

Diff 10292

View Options

src/script/interpreter.cpp

Loading...