Page MenuHomePhabricator
Differential D4041

Remove ContextualCheckBlock's dependency on Config
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2019, 17:13.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING94ce7c312269: Remove ContextualCheckBlock's dependency on Config
rABC94ce7c312269: Remove ContextualCheckBlock's dependency on Config
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ContextualCheckBlockconsensus
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7414
Build 12871: Bitcoin ABC Buildbot (legacy)
Build 12870: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2019, 17:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 17:13
teamcity added a comment.Sep 11 2019, 17:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7394: Diff 11208.Sep 11 2019, 17:22
teamcity added a comment.Sep 11 2019, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox requested changes to this revision.Sep 11 2019, 17:52
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
3692 ↗(On Diff #11208)

Keep the name consensusParams and move after state.

This revision now requires changes to proceed.Sep 11 2019, 17:52
deadalnix updated this revision to Diff 11237.Sep 12 2019, 09:22

Rebase and change parameter order

teamcity added a comment.Sep 12 2019, 09:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 09:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7414: Diff 11237.Sep 12 2019, 09:50
deadalnix added a child revision: D4050: Remove ConnectBlock's dependency on Config.Sep 12 2019, 10:31
jasonbcox accepted this revision.Sep 12 2019, 15:35
This revision is now accepted and ready to land.Sep 12 2019, 15:35
Closed by commit rABC94ce7c312269: Remove ContextualCheckBlock's dependency on Config (authored by deadalnix). · Explain WhySep 12 2019, 16:19
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC94ce7c312269: Remove ContextualCheckBlock's dependency on Config.
deadalnix added a commit: rSTAGING94ce7c312269: Remove ContextualCheckBlock's dependency on Config.Sep 19 2019, 02:16

Revision Contents
Changeset List

PathSize
src/
24 lines

Diff 11237

View Options

src/validation.cpp

Loading...