[CI] Workaround ubsan failure in functional tests
ClosedPublic
Actions

Authored by Fabien on Sep 4 2019, 15:41.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGad90b7f1a34b: [CI] Workaround ubsan failure in functional tests
rABCad90b7f1a34b: [CI] Workaround ubsan failure in functional tests

Summary

This will allow to run the undefined behavior sanitizer on the
functional tests.
For now the abc-p2p-compactblocks functional test is failing with ubsan (a message is missed, with no log) and the node fails to shut down, which causes the build to hang until timeout. This test is excluded from the list in order to allow for the other tests to run with ubsan, waiting for a fix.

Depends on D3993.

Test Plan

Run the CI build-ubsan build configuration.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ubsan_workaround

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7487
Build 13017: Bitcoin ABC Buildbot (legacy)
Build 13016: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 4 2019, 15:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2019, 15:41

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7316: Diff 11082.Sep 4 2019, 15:59

A better description/rationale as we discussed earlier.

This revision now requires changes to proceed.Sep 6 2019, 21:26

Fabien edited the summary of this revision. (Show Details)Sep 7 2019, 05:51

Rebase, improve summary and add a comment asking for removal in the future.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7360: Diff 11152.Sep 7 2019, 06:03

It would probably be more useful to fix the undefined behavior.

I'd rather fix it, but so far I failed to do so.
This is most likely not an undefined behavior, because ubsan doesn't catch anything, I rather suspect some kind of timing issue exhibited by running ubsan.

jasonbcox accepted this revision.Sep 9 2019, 16:35

This revision is now accepted and ready to land.Sep 9 2019, 16:35

Rebase

Build Bitcoin-ABC / Diffs / Diff Testing started.