Page MenuHomePhabricator
Differential D4280

Minor cleanups for AcceptToMemoryPool
AbandonedPublic
Actions

Authored by fpelliccioni on Oct 22 2019, 19:35.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Summary

First commit just removes default arguments from AcceptToMemoryPool and consolidates two arguments, it does not change behavior.

Backport of Bitcoin Core PR11309
https://github.com/bitcoin/bitcoin/pull/11309

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-93d20a734
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7836
Build 13693: Bitcoin ABC Buildbot (legacy)
Build 13692: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Oct 22 2019, 19:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2019, 19:35
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Oct 22 2019, 19:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni updated this revision to Diff 13647.Oct 22 2019, 19:42

removed comment

teamcity added a comment.Oct 22 2019, 19:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B7836: Diff 13646!Oct 22 2019, 19:46
teamcity added a comment.Oct 22 2019, 19:46

Build Bitcoin-ABC / Diffs / Diff Testing failed.

fpelliccioni edited the test plan for this revision. (Show Details)Oct 22 2019, 19:47
teamcity added a comment.Oct 22 2019, 19:55

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7837: Diff 13647!Oct 22 2019, 19:55
fpelliccioni planned changes to this revision.Oct 22 2019, 20:03

Have to check what happened with the tests.

fpelliccioni abandoned this revision.Nov 19 2019, 17:06
markblundeberg added a subscriber: markblundeberg.Dec 18 2019, 00:42

I am going to be reviving this soon, it makes more sense after having D4745.

markblundeberg added a comment.Dec 22 2019, 03:50

OK just did a new one, D4796

Revision Contents
Changeset List

Diff 13646

View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/txvalidation_tests.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...