Don't log RandAddSeedPerfmon details
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 22:42.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING7772233a9c64: Don't log RandAddSeedPerfmon details
rABC7772233a9c64: Don't log RandAddSeedPerfmon details

Summary

These are hard to deal with, as in a follow-up this function can get
called before the logging infrastructure is initialized.

Partial Backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/2d1cc5093949f8ea9487a68724162c8b39035ad8

Depends on D4387

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14955-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7999
Build 13996: Bitcoin ABC Buildbot (legacy)
Build 13995: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 5 2019, 22:42

Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 22:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 22:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4390: Automatically initialize RNG on first use..Nov 5 2019, 22:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7999: Diff 13940.Nov 5 2019, 22:53

jasonbcox accepted this revision.Nov 5 2019, 22:56

This revision is now accepted and ready to land.Nov 5 2019, 22:56

Closed by commit rABC7772233a9c64: Don't log RandAddSeedPerfmon details (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 15:55

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC7772233a9c64: Don't log RandAddSeedPerfmon details.

nakihito added a commit: rSTAGING7772233a9c64: Don't log RandAddSeedPerfmon details.Apr 7 2020, 21:38

Revision Contents
Changeset List

Path

Size

src/

random.cpp

15 lines

Diff 13940

View Options

Don't log RandAddSeedPerfmon detailsClosedPublicActions