Remove hwrand_initialized.
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 23:04.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGaf8c85a3613a: Remove hwrand_initialized.
rABCaf8c85a3613a: Remove hwrand_initialized.

Summary

All access to hwrand is now gated by GetRNGState, which initializes the hwrand code.

Partial backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/4ea8e50837a0932b31a241988fd68d6730a2048a

Depends on D4396

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Nov 5 2019, 23:04

Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 23:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 23:04

nakihito added a child revision: D4398: DRY: Implement GetRand using FastRandomContext::randrange.Nov 5 2019, 23:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8008: Diff 13949.Nov 5 2019, 23:24

Fabien accepted this revision.Nov 6 2019, 09:56

This revision is now accepted and ready to land.Nov 6 2019, 09:56

Closed by commit rABCaf8c85a3613a: Remove hwrand_initialized. (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 18:57

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCaf8c85a3613a: Remove hwrand_initialized..

nakihito added a commit: rSTAGINGaf8c85a3613a: Remove hwrand_initialized..Apr 7 2020, 21:39

Revision Contents
Changeset List

Path

Size

src/

random.cpp

4 lines

Diff 14003

View Options

Remove hwrand_initialized.ClosedPublicActions