Details
- Reviewers
deadalnix Fabien jasonbcox - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGING8fc1ee3ece76: Add a separate executable for seeder tests
rABC8fc1ee3ece76: Add a separate executable for seeder tests
../configure make check src/seeder/test_bitcoin-seeder ../configure CXX=clang++ CC=clang make clean make check src/seeder/test_bitcoin-seeder ninja ninja check
These should build everything including the seeder and seeder tests.
ninja test_bitcoin-seeder
This should only build test_bitcoin-seeder
ninja check-bitcoin-seeder
This should only run the bitcoin-seeder tests.
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- SeederTestExec
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8083 Build 14155: Bitcoin ABC Buildbot (legacy) Build 14154: arc lint + arc unit
Event Timeline
| src/seeder/CMakeLists.txt | ||
|---|---|---|
| 8 ↗ | (On Diff #14023) | Clearly, you have a configuration problem with your text editor. |
| 13 ↗ | (On Diff #14023) | This whole thing is very confusing. There is a seeder target and a bitcoin-seeder one. Does that mean the seeder target contain all the logic of the seeder, at the exclusion of bitcoin specific ones? If so why does it have a bitcoin.cpp file in it? Why is that target defined in the middle of the seeder's definition? They do not seem to even link with each other in the current state. Does this even produce a seeder that works at all? |
| src/seeder/test/CMakeLists.txt | ||
| 32 ↗ | (On Diff #14023) | This is duplicated code and calls for some refactoring. |
Changed CMake names to be more descriptive, Updated copyright missing copyright lines, fixed formatting, and rebased to remove duplicate code.
Removed LIBUNIVALUE from autotools and removed unnecessary change in seeder/CMake.txt.
| src/seeder/CMakeLists.txt | ||
|---|---|---|
| 7 ↗ | (On Diff #14268) | It's not necessary at all |
| src/seeder/test/seeder_tests.cpp | ||
|---|---|---|
| 11 ↗ | (On Diff #14332) | The test name obviously does not match the content |
Please add the new test path to the lint-tests linter in the .arclint file, and fix the boost test suite name accordingly.