Differential D4528

Merge #13498: [wallet] Fixups from account API deprecation
ClosedPublic
Actions

Authored by jasonbcox on Nov 23 2019, 17:28.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGd4fbe46116a2: Merge #13498: [wallet] Fixups from account API deprecation
rABCd4fbe46116a2: Merge #13498: [wallet] Fixups from account API deprecation

Summary

df10f07db1 [wallet] Don't use accounts when checking balance in sendmany (John Newbery)
e209184101 [wallet] deprecate sendfrom RPC method. (John Newbery)

Pull request description:

A couple of fixups from the accounts API deprecation PR (#12953):

- properly deprecate `sendfrom`
- don't use accounts when calculating balance in `sendmany` (unless the `-deprecatedrpc=accounts` flag is being used)

Tree-SHA512: 1befde055067438c4c3391bbff1aaed0e6249efd708c567db3f1faad40a0f28e64f95e5bad0679ae826d24a0239e4bc8a1c392dc93e2e7502343a7f6b1d1845c

Backport of Core PR13498
https://github.com/bitcoin/bitcoin/pull/13498/files

Depends on D4519

Test Plan

ninja check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13498

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8253
Build 14531: Default Diff Build & Tests
Build 14530: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 23 2019, 17:28

Herald added a reviewer: deadalnix. · View Herald TranscriptNov 23 2019, 17:28

jasonbcox planned changes to this revision.Nov 23 2019, 17:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Nov 23 2019, 17:29

jasonbcox added a parent revision: D4519: [wallet] [rpc] Remove getlabeladdress RPC.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8253: Diff 14355.Nov 23 2019, 17:38

jasonbcox requested review of this revision.Nov 23 2019, 17:42

jasonbcox added inline comments.

test/functional/wallet_labels.py
119	The missing change from the PR is due to D1799

Fabien accepted this revision.Nov 24 2019, 09:51

This revision is now accepted and ready to land.Nov 24 2019, 09:51

Closed by commit rABCd4fbe46116a2: Merge #13498: [wallet] Fixups from account API deprecation (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by jasonbcox). · Explain WhyNov 26 2019, 23:35

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCd4fbe46116a2: Merge #13498: [wallet] Fixups from account API deprecation.

jasonbcox added a commit: rSTAGINGd4fbe46116a2: Merge #13498: [wallet] Fixups from account API deprecation.Apr 7 2020, 21:52

Revision Contents
Changeset List

Path

Size

src/

wallet/

25 lines

test/

functional/

wallet_labels.py

6 lines

Diff 14355

src/wallet/rpcwallet.cpp

Loading...

test/functional/wallet_labels.py

Loading...