refactoring: add a method for determining if a block is pruned or not
ClosedPublic
Actions

Authored by majcosta on Dec 3 2019, 20:55.

Details

Reviewers

deadalnix
nakihito
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa8257058a391: refactoring: add a method for determining if a block is pruned or not
rABCa8257058a391: refactoring: add a method for determining if a block is pruned or not

Summary

"The check for whether a block is pruned or not is sufficiently obscure that it deserves a macro. It is also used in 2 places, ~~with more coming, e.g. #10757~~ (turns out it was a move, not an addition)."

This is a backport from Core PR13259: https://github.com/bitcoin/bitcoin/pull/13259

Test Plan

ninja check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-isblockpruned

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8391
Build 14800: Default Diff Build & Tests
Build 14799: arc lint + arc unit

Event Timeline

majcosta created this revision.Dec 3 2019, 20:55

Owners added a reviewer: Restricted Owners Package.Dec 3 2019, 20:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2019, 20:55

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito accepted this revision.Dec 3 2019, 20:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8391: Diff 14599.Dec 3 2019, 21:08

jasonbcox requested changes to this revision.Dec 3 2019, 23:18

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/validation.h
745	Is there a reason the function isn't inlined like in the original PR?

This revision now requires changes to proceed.Dec 3 2019, 23:18

majcosta added inline comments.Dec 4 2019, 02:04

src/validation.h
745	I decided not to because that would require me to `#include <chain.h>` as well. I don't know whether that function is called often enough to justify that dependency, but we can definitely inline it if that's best.