Details

Reviewers

deadalnix
freetrader

Group Reviewers

Restricted Project

Commits

rSTAGING16cdff0a1f55: Convert coins.cpp and coins.h to use Amount struct
rABC16cdff0a1f55: Convert coins.cpp and coins.h to use Amount struct

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

shammah/amount3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 964
Build 964: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 8 2017, 21:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2017, 21:48

Harbormaster completed remote builds in B963: Diff 1518.Oct 8 2017, 21:48

Convert net and net_processing to use Amount

Harbormaster completed remote builds in B964: Diff 1519.Oct 8 2017, 21:57

Revert to changes without net_processing.cpp

deadalnix added inline comments.Oct 9 2017, 09:45

src/validation.cpp
808 ↗	(On Diff #1520)	Looks like you missed that one ?

schancel added inline comments.Oct 9 2017, 16:45

src/validation.cpp
808 ↗	(On Diff #1520)	This was left alone because I hadn't fixed ApplyDeltas yet. These changes are just what is necessary to deal with the changes to coins.cpp

Rebase

deadalnix accepted this revision.Oct 9 2017, 17:42

deadalnix added inline comments.

src/bench/ccoins_caching.cpp
87 ↗	(On Diff #1524)	You should use a constructor here. It's still fishy that int convert to amount implicitly :/

This revision is now accepted and ready to land.Oct 9 2017, 17:42

Closed by commit rABC16cdff0a1f55: Convert coins.cpp and coins.h to use Amount struct (authored by schancel, committed by schancel). · Explain WhyOct 9 2017, 18:45

This revision was automatically updated to reflect the committed changes.

Convert coins.cpp and coins.h to use Amount struct
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1519

src/bench/ccoins_caching.cpp

src/chainparams.cpp

src/coins.h

src/coins.cpp

src/net.h

src/net_processing.cpp

src/validation.cpp

Convert coins.cpp and coins.h to use Amount structClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1519

src/bench/ccoins_caching.cpp

src/chainparams.cpp

src/coins.h

src/coins.cpp

src/net.h

src/net_processing.cpp

src/validation.cpp

Convert coins.cpp and coins.h to use Amount struct
ClosedPublic
Actions

Revision Contents
Changeset List