Page MenuHomePhabricator
Differential D4612

tests: Use MakeUnique to construct objects owned by unique_ptrs
ClosedPublic
Actions

Authored by Fabien on Dec 2 2019, 13:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING14b215f0d87a: tests: Use MakeUnique to construct objects owned by unique_ptrs
rABC14b215f0d87a: tests: Use MakeUnique to construct objects owned by unique_ptrs
Summary

As per title.

Backport of core PR14287:
https://github.com/bitcoin/bitcoin/pull/14287/files

Depends on D4588.

Several changes are missing because already in our codebase.

Test Plan
ninja check bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14287
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9380
Build 16691: Default Diff Build & Tests
Build 16690: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 2 2019, 13:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2019, 13:36
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 2 2019, 13:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 2 2019, 13:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8370: Diff 14555.Dec 2 2019, 13:58
deadalnix accepted this revision.Dec 2 2019, 17:26
This revision is now accepted and ready to land.Dec 2 2019, 17:26
Fabien updated this revision to Diff 16100.Feb 7 2020, 11:10

Rebase.

teamcity added a comment.Feb 7 2020, 11:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 7 2020, 11:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9319: Diff 16100.Feb 7 2020, 11:17
Fabien updated this revision to Diff 16204.Feb 10 2020, 10:55

Rebase.

teamcity added a comment.Feb 10 2020, 10:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 10 2020, 11:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9380: Diff 16204.Feb 10 2020, 11:17
Closed by commit rABC14b215f0d87a: tests: Use MakeUnique to construct objects owned by unique_ptrs (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyFeb 10 2020, 13:19
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC14b215f0d87a: tests: Use MakeUnique to construct objects owned by unique_ptrs.
Fabien added a commit: rSTAGING14b215f0d87a: tests: Use MakeUnique to construct objects owned by unique_ptrs.Apr 7 2020, 22:56

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
bench/
4 lines
test/
2 lines
21 lines
3 lines
wallet/
test/
4 lines

Diff 16204

View Options

doc/developer-notes.md

Loading...
View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/test/allocator_tests.cpp

Loading...
View Options

src/test/checkqueue_tests.cpp

Loading...
View Options

src/test/test_bitcoin_fuzzy.cpp

Loading...
View Options

src/wallet/test/coinselector_tests.cpp

Loading...