Page MenuHomePhabricator
Differential D5416

[wallet] Remove ListAccountCreditDebit()
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 19:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5ec97bc2a80f: [wallet] Remove ListAccountCreditDebit()
rABC5ec97bc2a80f: [wallet] Remove ListAccountCreditDebit()
Summary

Function no longer used.

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/b7fd01a5539c6daa408d38adea3a4a7ee4a5ad4d

Depends on D5412, D5414, D5415

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9712
Build 17317: Default Diff Build & Tests
Build 17316: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 19:54
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 19:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 19:55
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 19:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 3 2020, 19:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 20:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9712: Diff 16743.Mar 3 2020, 20:05
nakihito added a child revision: D5418: [wallet] Remove CAccountingEntry class.Mar 3 2020, 20:16
Fabien requested changes to this revision.Mar 4 2020, 08:17
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests). I ran the tests myself for D5414 and D5415 but won't do for the whole stack.

This revision now requires changes to proceed.Mar 4 2020, 08:17
nakihito requested review of this revision.Mar 4 2020, 18:45
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

Fabien accepted this revision.Mar 5 2020, 07:20
Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 5 2020, 07:21
Closed by commit rABC5ec97bc2a80f: [wallet] Remove ListAccountCreditDebit() (authored by nakihito). · Explain WhyMar 6 2020, 18:30
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC5ec97bc2a80f: [wallet] Remove ListAccountCreditDebit().
nakihito added a commit: rSTAGING5ec97bc2a80f: [wallet] Remove ListAccountCreditDebit().Apr 7 2020, 23:16

Revision Contents
Changeset List

PathSize
src/
wallet/
3 lines
52 lines

Diff 16743

View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...