Page MenuHomePhabricator

[wallet] Remove fromAccount argument from CommitTransaction()
ClosedPublic

Authored by nakihito on Mar 3 2020, 22:21.

Details

Summary
Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-10
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9718
Build 17329: Default Diff Build & Tests
Build 17328: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 22:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Mar 4 2020, 08:18
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests).

This revision now requires changes to proceed.Mar 4 2020, 08:18
nakihito requested review of this revision.Mar 4 2020, 19:14
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

The diff is pollution by several unrelated linter formatting changes, but the code looks good.

This revision is now accepted and ready to land.Mar 5 2020, 07:47