Page MenuHomePhabricator
Differential D5820

[backport#15288] Remove use of GetCountWithDescendants in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 23 2020, 21:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe925b2dd0869: [backport#15288] Remove use of GetCountWithDescendants in wallet code
rABCe925b2dd0869: [backport#15288] Remove use of GetCountWithDescendants in wallet code
Summary

291276f7f40df9fcd62e54c016953705bf0ed04a This commit does not change behavior. (Russell Yanofsky)

Depends on D5819

This is a partial backport of Core PR15288.

Test Plan
cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10371
Build 18563: Default Diff Build & Tests
Build 18562: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 23 2020, 21:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2020, 21:06
teamcity edited the summary of this revision. (Show Details)Apr 23 2020, 21:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 23 2020, 21:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 23 2020, 21:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10371: Diff 19069.Apr 23 2020, 21:16
majcosta mentioned this in D5819: [backport#15288] Remove use of IsRBFOptIn in wallet code.Apr 23 2020, 21:32
deadalnix accepted this revision.Apr 23 2020, 22:27
This revision is now accepted and ready to land.Apr 23 2020, 22:27
majcosta edited the test plan for this revision. (Show Details)Apr 23 2020, 22:52
Closed by commit rABCe925b2dd0869: [backport#15288] Remove use of GetCountWithDescendants in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 24 2020, 15:14
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe925b2dd0869: [backport#15288] Remove use of GetCountWithDescendants in wallet code.
majcosta added a child revision: D5826: [backport#15288] Remove use of GetTransactionAncestry in wallet code.Apr 24 2020, 17:03
majcosta added a commit: rSTAGINGe925b2dd0869: [backport#15288] Remove use of GetCountWithDescendants in wallet code.May 5 2020, 19:07

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
6 lines

Diff 19069

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...