Page MenuHomePhabricator
Differential D5858

[backport#15288] Remove uses of InitMessage/Warning/Error in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 27 2020, 18:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING78e4b0b55c00: [backport#15288] Remove uses of InitMessage/Warning/Error in wallet code
rABC78e4b0b55c00: [backport#15288] Remove uses of InitMessage/Warning/Error in wallet code
Summary

e2c8ba9f6e782e2545b71e9e34b967c69e18c7f0 This commit does not change behavior. (Russell Yanofsky)

Depends on D5854

This is a partial backport of Core PR15288

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10433
Build 18687: Default Diff Build & Tests
Build 18686: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 27 2020, 18:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2020, 18:12
teamcity edited the summary of this revision. (Show Details)Apr 27 2020, 18:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 27 2020, 18:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.Apr 27 2020, 18:24
This revision is now accepted and ready to land.Apr 27 2020, 18:24
teamcity added a comment.Apr 27 2020, 18:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10433: Diff 19169.Apr 27 2020, 18:31
Closed by commit rABC78e4b0b55c00: [backport#15288] Remove uses of InitMessage/Warning/Error in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 28 2020, 00:55
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC78e4b0b55c00: [backport#15288] Remove uses of InitMessage/Warning/Error in wallet code.
majcosta added a child revision: D5866: [backport#15288] Remove use of AcceptToMemoryPool in wallet code.Apr 28 2020, 03:59
majcosta added a commit: rSTAGING78e4b0b55c00: [backport#15288] Remove uses of InitMessage/Warning/Error in wallet code.May 5 2020, 19:10

Revision Contents
Changeset List

PathSize
src/
interfaces/
9 lines
10 lines
wallet/
20 lines
86 lines

Diff 19169

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...