Refactor keymetadata writing to a separate method
ClosedPublic
Actions

Authored by nakihito on May 7 2020, 20:18.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCeb725bf601e3: Refactor keymetadata writing to a separate method

Summary

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/c45415f73a095665a8ff6172b57eb818cf572547

Test Plan

ninja
ninja check
ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14021-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10976
Build 20176: Default Diff Build & Tests
Build 20175: Build without Wallet
Build 20174: Build with clang-10
Build 20173: arc lint + arc unit

Event Timeline

nakihito created this revision.May 7 2020, 20:18

Owners added a reviewer: Restricted Owners Package.May 7 2020, 20:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 20:18

nakihito requested review of this revision.May 7 2020, 20:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito planned changes to this revision.May 7 2020, 20:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10650: Diff 19829.May 7 2020, 20:46

Rebase.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10949: Diff 20477.May 21 2020, 19:12

nakihito added a child revision: D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.May 21 2020, 19:26

nakihito planned changes to this revision.May 21 2020, 19:47

nakihito requested review of this revision.May 21 2020, 22:54

nakihito added a child revision: D6215: Test importing descriptors with key origin information and add release notes.May 21 2020, 22:58

Fabien requested changes to this revision.May 22 2020, 11:52

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/walletdb.cpp
84 ↗	(On Diff #20477)	No overwrite

This revision now requires changes to proceed.May 22 2020, 11:52

Fixed overwrite.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10976: Diff 20522.May 22 2020, 17:56

Fabien accepted this revision.May 22 2020, 18:57

This revision is now accepted and ready to land.May 22 2020, 18:57

nakihito removed a child revision: D6215: Test importing descriptors with key origin information and add release notes.May 22 2020, 19:54

Closed by commit rABCeb725bf601e3: Refactor keymetadata writing to a separate method (authored by Andrew Chow <achow101-github@achow101.com>, committed by nakihito). · Explain WhyMay 22 2020, 22:27

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABCeb725bf601e3: Refactor keymetadata writing to a separate method.

Revision Contents
Changeset List

Path

Size

src/

wallet/

walletdb.h

2 lines

walletdb.cpp

12 lines

Diff 20522

View Options

src/wallet/walletdb.h