[backport#13756] wallet: enable avoid_reuse feature
ClosedPublic
Actions

Authored by majcosta on Jun 8 2020, 21:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

Partial backport of Core PR13756

Test Plan

ninja check

the proper functional test for this feature is included in a posterior commit D6466

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11352
Build 21604: Default Diff Build & Tests
Build 21603: Build without Wallet
Build 21602: Build with clang-10
Build 21601: arc lint + arc unit

majcosta requested review of this revision.Jun 8 2020, 21:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the test plan for this revision. (Show Details)Jun 8 2020, 21:33

Fabien requested changes to this revision.Jun 9 2020, 07:00

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/wallet.cpp
1121 ↗	(On Diff #21116)	Move the comment on its line
src/wallet/wallet.h
1064 ↗	(On Diff #21116)	Nit: `TxId &hash` => `TxId &txid` This makes it more consistent with other parts of the code