Page MenuHomePhabricator
Differential D6460

Move GenerateSelectSet logic to private method.
ClosedPublic
Actions

Authored by nakihito on Jun 8 2020, 20:07.

Details

Reviewers
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC716ac6e899ad: Move GenerateSelectSet logic to private method.
Summary

This separates the socket event collection logic from the logic
deciding which events we're interested in at all.

Partial backport of Core PR14336
https://github.com/bitcoin/bitcoin/pull/14336/commits/7e403c0ae705455aa66f7df9a9a99f462fd4e9a8

Depends on D6459

Test Plan
ninja
ninja check-all
src/bitcoind -debug=net

Verify normal node connection behavior

Diff Detail

Event Timeline

nakihito created this revision.Jun 8 2020, 20:07
Owners added a reviewer: Restricted Owners Package.Jun 8 2020, 20:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 20:07
nakihito requested review of this revision.Jun 8 2020, 20:07
nakihito planned changes to this revision.
teamcity edited the summary of this revision. (Show Details)Jun 8 2020, 20:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11329: Diff 21110.Jun 8 2020, 20:17
nakihito edited the summary of this revision. (Show Details)Jun 8 2020, 22:14
nakihito added a parent revision: D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..
nakihito added a child revision: D6461: Move SocketEvents logic to private method..
nakihito requested review of this revision.Jun 8 2020, 22:16
Fabien accepted this revision.Jun 9 2020, 06:43
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.cpp
1284 ↗(On Diff #21110)

Nit: Comment on its line

This revision is now accepted and ready to land.Jun 9 2020, 06:43
nakihito updated this revision to Diff 21156.Jun 9 2020, 17:12

Addressed nit.

Harbormaster completed remote builds in B11358: Diff 21156.Jun 9 2020, 17:30
jasonbcox accepted this revision.Jun 9 2020, 23:02
Closed by commit rABC716ac6e899ad: Move GenerateSelectSet logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>, committed by nakihito). · Explain WhyJun 9 2020, 23:21
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC716ac6e899ad: Move GenerateSelectSet logic to private method..

Revision Contents
Changeset List

PathSize
src/
3 lines
92 lines

Diff 21156

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...