[backport#17261 2/13] Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman
ClosedPublic
Actions

Authored by majcosta on Oct 9 2020, 03:27.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rABCb820c50ea939: [backport#17261 2/13] Locking: Lock cs_KeyStore instead of cs_wallet in legacy…

Summary

This commit only affects locking behavior and doesn't have other changes.

https://github.com/bitcoin/bitcoin/pull/17261/commits/fadc08ad944cad42e805228cdd58e0332f4d7184

Partial backport of Core PR17261

Test Plan

cmake -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS=-Werror
ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17261

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13288
Build 26616: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26615: arc lint + arc unit

Event Timeline

majcosta created this revision.Oct 9 2020, 03:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2020, 03:27

majcosta requested review of this revision.Oct 9 2020, 03:27

teamcity edited the summary of this revision. (Show Details)Oct 9 2020, 03:27

Harbormaster completed remote builds in B13288: Diff 24434.Oct 9 2020, 03:42

Please update the test plan to detect locking issues. Run the tests with debug enabled to detect any AssertLockHeld() assertion and with clang to check against the thread-safety annotations.

This revision now requires changes to proceed.Oct 9 2020, 06:37

rebase

majcosta edited the test plan for this revision. (Show Details)Oct 9 2020, 13:52

majcosta edited the test plan for this revision. (Show Details)

deadalnix accepted this revision.Oct 9 2020, 14:13

Harbormaster completed remote builds in B13298: Diff 24455.Oct 9 2020, 14:17

majcosta added a child revision: D7848: [backport#17261 3/13] Refactor: Allow LegacyScriptPubKeyMan to be null.Oct 9 2020, 14:55

majcosta edited the summary of this revision. (Show Details)Oct 9 2020, 14:58

Fabien accepted this revision.Oct 9 2020, 15:35

This revision is now accepted and ready to land.Oct 9 2020, 15:35

Closed by commit rABCb820c50ea939: [backport#17261 2/13] Locking: Lock cs_KeyStore instead of cs_wallet in legacy… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyOct 9 2020, 22:33

This revision was automatically updated to reflect the committed changes.