Page MenuHomePhabricator

[backport#17261 2/13] Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman
ClosedPublic

Authored by majcosta on Oct 9 2020, 03:27.

Details

Summary

This commit only affects locking behavior and doesn't have other changes.

https://github.com/bitcoin/bitcoin/pull/17261/commits/fadc08ad944cad42e805228cdd58e0332f4d7184


Partial backport of Core PR17261

Test Plan
cmake -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS=-Werror
ninja all check check-functional

Event Timeline

majcosta requested review of this revision.Oct 9 2020, 03:27
Fabien requested changes to this revision.Oct 9 2020, 06:37
Fabien added a subscriber: Fabien.

Please update the test plan to detect locking issues. Run the tests with debug enabled to detect any AssertLockHeld() assertion and with clang to check against the thread-safety annotations.

This revision now requires changes to proceed.Oct 9 2020, 06:37
majcosta edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Oct 9 2020, 15:35