Page MenuHomePhabricator
Differential D954

Backport the getchaintxstatsrpc RPC
ClosedPublic
Actions

Authored by deadalnix on Jan 14 2018, 19:01.

Details

Reviewers
schancel
dagurval
Group Reviewers
Restricted Project
Commits
rSTAGING30998545f110: Backport the getchaintxstatsrpc RPC
rABC30998545f110: Backport the getchaintxstatsrpc RPC
Summary

As per title.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getchaintxstatsrpc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1605
Build 1605: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 14 2018, 19:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2018, 19:01
dagurval accepted this revision.Jan 15 2018, 11:24
dagurval added a subscriber: dagurval.

LGTM. A couple of nits. You forgot attribution.

src/rpc/blockchain.cpp
1633

Nit: Perhaps something to indicate that the default is not exactly one month, but an approximation? approx. one moth

1672

Nit: Why create a new scope, instead of using the if scope above?

This revision is now accepted and ready to land.Jan 15 2018, 11:24
Closed by commit rABC30998545f110: Backport the getchaintxstatsrpc RPC (authored by deadalnix). · Explain WhyJan 15 2018, 11:46
This revision was automatically updated to reflect the committed changes.
teamcity mentioned this in T160: Revision D954 broke builds.Jan 15 2018, 12:25
teamcity added a subscriber: teamcity.

This revision has failed testing.

jasonbcox mentioned this in D2909: Merge #11238: Add assertions before potential null deferences.May 2 2019, 21:01
markblundeberg added a subscriber: markblundeberg.May 9 2019, 02:05

Failed attribution

backport PR9733 https://github.com/bitcoin/bitcoin/pull/9733/files

nakihito mentioned this in D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.Sep 4 2019, 21:36

Revision Contents
Changeset List

PathSize
src/
rpc/
101 lines
1 line
test/
functional/
36 lines

Diff 2500

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

test/functional/blockchain.py

Loading...