Page MenuHomePhabricator

Backport the getchaintxstatsrpc RPC
ClosedPublic

Authored by deadalnix on Jan 14 2018, 19:01.

Details

Summary

As per title.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getchaintxstatsrpc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1605
Build 1605: arc lint + arc unit

Event Timeline

dagurval added a subscriber: dagurval.

LGTM. A couple of nits. You forgot attribution.

src/rpc/blockchain.cpp
1633

Nit: Perhaps something to indicate that the default is not exactly one month, but an approximation? approx. one moth

1672

Nit: Why create a new scope, instead of using the if scope above?

This revision is now accepted and ready to land.Jan 15 2018, 11:24
This revision was automatically updated to reflect the committed changes.